Reviewed 18 of 23 files at r1, all commit messages.
Reviewable status: 18 of 23 files reviewed, 7 unresolved discussions (waiting on @mojganii)

ios/MullvadMockData/MullvadREST/RelaySelectorStub.swift line 15 at r1 (raw file):

/// Relay selector stub that accepts a block that can be used to provide custom implementation.
public final class RelaySelectorStub: RelaySelectorProtocol {
    var block: (RelayConstraints, UInt) throws -> SelectedRelays

How about we rename this selectRelaysResult

ios/MullvadVPN/TunnelManager/TunnelManager.swift line 29 at r1 (raw file):

//        switch self {
//            object.build(for theCase)
//        }

Let's remove these comments

ios/MullvadVPN/TunnelManager/TunnelManager.swift line 100 at r1 (raw file):

//    #else
//    internal var MappingOperation = MapConnectionStatusOperation.self
//    #endif

These too

ios/MullvadVPN/TunnelManager/TunnelManager.swift line 940 at r1 (raw file):

//            queue: internalQueue,
//            interactor: TunnelInteractorProxy(self),
//            connectionStatus: connectionStatus,

And these as well

ios/MullvadVPNTests/MullvadVPN/TunnelManager/TunnelManagerTests.swift line 122 at r1 (raw file):

    }

    func testExitBlockedStateAfterSatisfyingConstraints() async throws {

We can add a comment describing what the test does since the setup is quite complicated.
We could say something along the lines of

ios/MullvadVPNTests/MullvadVPN/TunnelManager/TunnelManagerTests.swift line 181 at r1 (raw file):

        await fulfillment(
            of: [blockedExpectation, connectedExpectation],
            timeout: .UnitTest.timeout

We want to make sure that the expectations are met in order here.

        await fulfillment(
            of: [blockedExpectation, connectedExpectation],
            timeout: .UnitTest.timeout,
            enforceOrder: true
        )

ios/PacketTunnelCore/Actor/PacketTunnelActor.swift line 287 at r1 (raw file):

        reason: ActorReconnectReason
    ) async throws {
        defer {

We should leave this after the call to stopDefaultPathObserver
Otherwise, this will be ran here even if obfuscateConnection throws an error (For example, invalid constraints in the relay selector) which is not a desired behaviour.

Reviewed 16 of 23 files at r1, 5 of 5 files at r2, 2 of 2 files at r3, 1 of 1 files at r4, all commit messages.
Reviewable status: all files reviewed, 12 unresolved discussions (waiting on @mojganii)

ios/MullvadRESTTests/TransportStrategyTests.swift line 9 at r3 (raw file):

//

@testable import MullvadMockData

Intentional import?

ios/MullvadVPN/TunnelManager/MapConnectionStatusOperation.swift line 25 at r3 (raw file):

    private let logger = Logger(label: "TunnelManager.MapConnectionStatusOperation")

    required init(

Is this change necessary?

ios/MullvadVPN/TunnelManager/SendTunnelProviderMessageOperation.swift line 63 at r3 (raw file):

        addObserver(
            BackgroundObserver(
                application: backgroundTaskProvider,

"application" should probably be renamed to "backgroundTaskProvider".

ios/MullvadVPN/TunnelManager/TunnelInteractor.swift line 19 at r3 (raw file):

    var tunnel: (any TunnelProtocol)? { get }
    var application: any BackgroundTaskProvider { get }

There is this and other places in the code where "application" hasn't been renamed to the match the new type.

ios/MullvadMockData/MullvadREST/AccessMethodRepository+Stub.swift line 12 at r4 (raw file):

import MullvadSettings

public struct AccessMethodRepositoryStub: AccessMethodRepositoryDataSource {

Do we need to make all these public?

Reviewed 5 of 23 files at r1, all commit messages.
Reviewable status: all files reviewed, 12 unresolved discussions (waiting on @mojganii)

Reviewed 4 of 23 files at r1, 5 of 5 files at r2, 2 of 2 files at r3, 1 of 1 files at r4, all commit messages.
Reviewable status: all files reviewed, 5 unresolved discussions (waiting on @mojganii)

Reviewable status: 18 of 27 files reviewed, 5 unresolved discussions (waiting on @buggmagnet and @rablador)

ios/MullvadMockData/MullvadREST/RelaySelectorStub.swift line 15 at r1 (raw file):

Done.

ios/MullvadRESTTests/TransportStrategyTests.swift line 9 at r3 (raw file):

AccessMethodRepositoryStub was moved to MullvadMockData .

ios/MullvadVPN/TunnelManager/MapConnectionStatusOperation.swift line 25 at r3 (raw file):

Which one is drawing your attention? I didn't get the difference.

ios/MullvadVPN/TunnelManager/SendTunnelProviderMessageOperation.swift line 63 at r3 (raw file):

Done.

ios/MullvadVPN/TunnelManager/TunnelInteractor.swift line 19 at r3 (raw file):

Done.

ios/MullvadVPN/TunnelManager/TunnelManager.swift line 29 at r1 (raw file):

Done.

ios/MullvadVPN/TunnelManager/TunnelManager.swift line 100 at r1 (raw file):

Done.

ios/MullvadVPN/TunnelManager/TunnelManager.swift line 940 at r1 (raw file):

Done.

ios/MullvadVPNTests/MullvadVPN/TunnelManager/TunnelManagerTests.swift line 122 at r1 (raw file):

Done.

ios/MullvadVPNTests/MullvadVPN/TunnelManager/TunnelManagerTests.swift line 181 at r1 (raw file):

Done.

ios/PacketTunnelCore/Actor/PacketTunnelActor.swift line 287 at r1 (raw file):

Done.

ios/MullvadMockData/MullvadREST/AccessMethodRepository+Stub.swift line 12 at r4 (raw file):

Yes, wea re using that in TunnelManagerTests.

Reviewed 9 of 9 files at r5, all commit messages.
Reviewable status: all files reviewed, 5 unresolved discussions (waiting on @rablador)

Reviewed 5 of 5 files at r6, all commit messages.
Reviewable status: all files reviewed, 5 unresolved discussions (waiting on @rablador)